Yannig hackathon #33
Yannig hackathon #33
Conversation
…t have access to Github
adding a bit of documentation
| [$pr_url]($pr_url) | ||
|
|
||
| --- | ||
| ${pr_body//###/####} |
There was a problem hiding this comment.
So replace all hading level 3 for level 4 headings isn't it?
Why? Just curious
There was a problem hiding this comment.
So, it's getting anything from 3, 4, 5 to 4,5..
I hope we are not using 2... And just because lvl 3 looks good in github, but way too big in Projects 😊
|
LGTM. Great job. |
|
Yop, I tested it locally, it's how I made the gif and the video 😊 I also changed the body in open test to have a complex markdown body in there 😊 |
|
@ychartois arrived late here. Just some questions:
|
| "number": 1, | ||
| "pull_request": { | ||
| "body": "This is the body of the PR. https://xxxx.teamwork.com/#/tasks/123 https://xxx.teamwork.com/#/tasks/456", | ||
| "body": "### Task\r\n- [Implement Smart Inbox Settings](https://digitalcrew.teamwork.com/#tasks/21419431)\r\n - Implement `<ConditionsBuilder/>`\r\n - Implement `<ConditonRow/>`\r\n\r\n### Screencap\r\n#### `<ConditionsBuilder/>`\r\n\r\n\r\n#### `<ConditonRow/>`\r\n- UI Explanation\r\n\r\n- Blank State\r\n\r\n- Empty State for not provided values\r\n - Tags\r\n \r\n - Companies\r\n \r\n- Validation Errors\r\n - Tags\r\n \r\n - Companies\r\n \r\n- Row Error (loading data error)\r\n\r\n- All Possible Condition Rows\r\n", |
There was a problem hiding this comment.
This is a public repository, we shouldn't be exposing our internal URLs. I would create a generic JSON just for testing purposes.
| local -r tag_name=$1 | ||
|
|
||
| if [ "$ENV" == "test" ]; then | ||
| log::message "Test - Simulate request. Task ID: $TEAMWORK_TASK_ID - Tag: ${tag_name//\"/}" |
There was a problem hiding this comment.
This line is for testing, I would add to the message something like "Removed tag".
| local -r tag_name=$1 | ||
|
|
||
| if [ "$ENV" == "test" ]; then | ||
| log::message "Test - Simulate request. Task ID: $TEAMWORK_TASK_ID - Tag: ${tag_name//\"/}" |
There was a problem hiding this comment.
This line is for testing, I would add to the message something like "Added tag".
|
I've also noted that titles are quite big in Teamwork. We should probably make smaller. |
Task
https://digitalcrew.teamwork.com/#tasks/17377853
When a PR is open, I'd like the all PR description to be past in the task comment, as most of customer facing people don't have access to Github
It also update the task tag to have a high vision of the flow
Screencast